fix: make stop action cancel AI generation immediately#140
Open
fix: make stop action cancel AI generation immediately#140
Conversation
Stop now aborts in-flight run/poll requests and finalizes the UI as cancelled immediately, preventing late chunks from rendering after cancellation. Add integration coverage for stop during active polling and before session initialization to lock in the behavior.
Member
|
But does this ensure that backend operations stop as soon as sensibly possible? |
Trigger best-effort Docker container termination when cancelling an edit session and treat cancellation-related runtime failures as cancelled. This makes stop requests interrupt backend work sooner and keeps session state aligned with user-triggered cancellation.
Member
|
looks like quality checks and php tests fail now. |
Route stop-triggered container termination through the WorkspaceTooling facade to keep architecture boundaries intact while still hard-stopping agent runtimes. Also ignore late polling payloads after cancellation so no additional output renders once Stop is pressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.