Skip to content

fix: make stop action cancel AI generation immediately#140

Open
JOORVIS wants to merge 3 commits intomainfrom
fix/94-stop-action-immediate-cancel
Open

fix: make stop action cancel AI generation immediately#140
JOORVIS wants to merge 3 commits intomainfrom
fix/94-stop-action-immediate-cancel

Conversation

@JOORVIS
Copy link
Collaborator

@JOORVIS JOORVIS commented Feb 22, 2026

No description provided.

Stop now aborts in-flight run/poll requests and finalizes the UI as cancelled immediately, preventing late chunks from rendering after cancellation. Add integration coverage for stop during active polling and before session initialization to lock in the behavior.
@manuelkiessling
Copy link
Member

But does this ensure that backend operations stop as soon as sensibly possible?

Trigger best-effort Docker container termination when cancelling an edit session and treat cancellation-related runtime failures as cancelled. This makes stop requests interrupt backend work sooner and keeps session state aligned with user-triggered cancellation.
@manuelkiessling
Copy link
Member

looks like quality checks and php tests fail now.

Route stop-triggered container termination through the WorkspaceTooling facade to keep architecture boundaries intact while still hard-stopping agent runtimes. Also ignore late polling payloads after cancellation so no additional output renders once Stop is pressed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants